Testing the commit checker with pull_request_target #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's sufficient to swap the req_complete with REQUEST_COMPLETED and look at the original value to decide whether a sync object was there. No need to first CAS and then swap. Signed-off-by: Joseph Schuchart <schuchart@icl.utk.edu>
and MPI_Info_get_valuelen related to open-mpi#9192 Signed-off-by: Howard Pritchard <howardp@lanl.gov>
…/PMPI functions Signed-off-by: David Wootton <dwootton@us.ibm.com>
The ompi_info man page moved into the docs/ directory with the rest of the man pages; it was accidentally left here in the ompi/tools/ompi_info directory. Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
Remove a bunch of stale kruft from the top-level .gitignore file: - Some man pages (which are now in the docs/tree) - Some MPI extensions/components that no longer exist - Some other directories that no longer exist - Mercurial metadata files/dirs Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
Signed-off-by: Mamzi Bayatpour <mbayatpour@nvidia.com>
Cleanup sync object handling in ompi_request_complete
Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
…date docs/news: Add 4.1.4 NEWS items
…nfo_get MPI4: deprecate MPI_Info_get
Signed-off-by: Joshua Hursey <jhursey@us.ibm.com>
Cleanup deprecation warning defines for MPI 4.0
Remove stale kruft
Specifically, 'command', 'wdir' and 'argv'. Pass down the argv and argc commands to the lower levels from MPI_Init(). In the singleton case, the PMIx calls to get these data will fail, so populate them when they do if provided. Nothing to do for the MPI_Sessions model, as it is not supported. 'wdir' can be populated with a good enough guess of getcwd(). Signed-off-by: Austen Lauria <awlauria@us.ibm.com>
…aunch Populate some additional MPI_INFO_ENV keys with singleton launch.
OSC/UCX: Adding locks to win attach/detach and fixing build warnings
PMIx commits since last update: 41f4225 - Fix IOF of stdin 7f458b5 - Update the dmodex example 518dc6a - Stop multiple invocations of debugger-release 7b741c4 - src/include/Makefile.am: avoid potential file corruption e78b8e5 - construct_dictionary.py: make .format() safe for Python 2 627731e - Cleanup some debug output 7931d87 - Add "const" qualifiers to some string print APIs 534cf08 - Fix potential use after free in tests d94a533 - Properly cast the list_item_t 1318c07 - Cleanup the pnet/sshot code for picky compilers 60b45ef - Fix dmodex operations eda31e0 - Add CPPFLAGS for pnet/sshot component 0daf8e2 - Fix show_help output to include tools c9e3f09 - Fix PMIX_INFO_*PROCESSED macros b46e350 - Update show-help system 735b29a - Remove bad destruct call 8352b86 - Enable pickyness by default in Git repo builds (openpmix/openpmix#2631) 03a8194 - Hide unused function b83c97f - Return "succeeded" status when outputting help/version info PRRTe commits since last update: 0b580da7c8 - Ensure rankfile and seq mappers computer local and app ranks 6ef02ea7a1 - Allow mapping in overload scenario if bind not specified. c385f74f35 - Add forwarding of stdin to indirect example f3d4089236 - Change the default mapping for --bind-to none option to BYSLOT. a252745b99 - Handle clean shutdown of stdin 090898fe4f - Fix stdin forwarding across nodes 15977f6ecf - Update the dmodex example 550897001d - Return the PMIx version of "not supported" 4b41c8e0a3 - Fix resource usage tracking for map/bind operations ccd3bafcbd - Revert debug commits c7dd6bbecb - REVERT ME ed79411103 - REVERT ME - DEBUG FOR PMIX-TESTS 06254c35d9 - Return zero status when outputting help/version info Signed-off-by: Austen Lauria <awlauria@us.ibm.com>
Update PRRTe and PMIx submodule pointers.
This adds comments onto the pull request containing what caused the commit checks to fail, if any, and suggests fixes to the user. If no errors are raised, no comment is made. GitHub says there's a limit of 65536 characters on comments. If the bot's comment is over that limit, it will truncate the comment to fit, and add a message explaining where the remaining errors can be found. Unfortunately, the GitHub API doesn't seem to provide a job's unique ID for linking to a job run (this is different than an action run: ".../runs/..." vs ".../actions/runs/...", respectively), so we can't directly link to the error messages printed to the console. Additionally, to create this link, two new environment variables are used: GITHUB_RUN_ID and GITHUB_SERVER_URL. Because we need the PR object twice, check_github_pr_description() was also changed to have the PR object passed into it; the PR object is gotten with a new function, get_github_pr(). The GitHub action configuration was changed to run on pull_request_target, instead of pull_request. This allows the action to be run in the context of the base of the PR, rather than in the context of the merge commit. Therefore, the action is run even if the PR has merge conflicts. Signed-off-by: Joe Downs <joe@dwns.dev>
git-commit-checks: comment on PR with error(s)
github-actions
bot
added
Target: pr/commit-checker-messages
and removed
Target: main
labels
Joe-Downs
changed the title
Joe-Downs
force-pushed
the
pr/commit-checker-messages
branch
3 times, most recently
from
b4f9788 to
4b0ce7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.