Skip to content

Update README with new features, GIF feature #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Sep 12, 2022

Conversation

TomPham97
Copy link
Contributor

No description provided.

I'm not entirely sure if it's a good idea to include the demonstration for limiting or deactivating token attribution in the main README.md, but feel free to merge or discard this as you wish.
the `output['all_samples_during_generation'].show() command in the original GIF is outdated
update the command and GIF
@JoaoLages JoaoLages self-requested a review September 11, 2022 17:50
@TomPham97
Copy link
Contributor Author

TomPham97 commented Sep 12, 2022

I forgot to fork to a different branch so my new GIF feature commits are automatically included in this PR. I'm still a beginner 😅

This is my first real code contribution so I would gladly appreciate your feedback and guidance. I use PIL save gif function to generate and save a GIF from the denoising process. The parameter show is set to True by default, so IPython will display this gif.

@TomPham97 TomPham97 changed the title Update README with new features Update README with new features, GIF feature Sep 12, 2022
@TomPham97
Copy link
Contributor Author

Just for the purpose of demonstration, this is what my GIF looks like with duration = 400 miliseconds:
denoising process gif

Copy link
Owner

@JoaoLages JoaoLages left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! The gif is really cool and easy to make, great idea!

Check my comments :)

TomPham97 and others added 6 commits September 12, 2022 14:28
Co-authored-by: João Lages <joaop.glages@gmail.com>
Co-authored-by: João Lages <joaop.glages@gmail.com>
Co-authored-by: João Lages <joaop.glages@gmail.com>
Co-authored-by: João Lages <joaop.glages@gmail.com>
Co-authored-by: João Lages <joaop.glages@gmail.com>
Gif contains an outdated command
@TomPham97
Copy link
Contributor Author

I would like to mention this GIF feature in README.md. To maintain consistency among photos when embedding a new GIF, do you have the parameters for this photo (seed, CFG, scheduler)?
Corgi Eiffel tower photo

@JoaoLages
Copy link
Owner

I would like to mention this GIF feature in README.md. To maintain consistency among photos when embedding a new GIF, do you have the parameters for this photo (seed, CFG, scheduler)? Corgi Eiffel tower photo

I will mention it in the notebooks instead, to leave the README more compact. You'll also get a mention in the credits section ;)

@JoaoLages JoaoLages merged commit 233ed37 into JoaoLages:main Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants