Implement async/sync tests for nbf claim (auth0#537)

Refactor the existing tests for the nbf claim to use the async/sync test helpers. This required fixing a case where an error was improperly handled for an async call.
JiteshShivnani · Oct 16, 2018 · 88bc965 · 88bc965
1 parent 9ae3f20
commit 88bc965
Show file tree

Hide file tree

Showing 2 changed files with 220 additions and 141 deletions.
diff --git a/sign.js b/sign.js
@@ -147,7 +147,12 @@ module.exports = function (payload, secretOrPrivateKey, options, callback) {
   }
 
   if (typeof options.notBefore !== 'undefined') {
-    payload.nbf = timespan(options.notBefore, timestamp);
+    try {
+      payload.nbf = timespan(options.notBefore, timestamp);
+    }
+    catch (err) {
+      return failure(err);
+    }
     if (typeof payload.nbf === 'undefined') {
       return failure(new Error('"notBefore" should be a number of seconds or string representing a timespan eg: "1d", "20h", 60'));
     }