This repository was archived by the owner on Oct 30, 2020. It is now read-only.
Add named exports option #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timse
force-pushed
the
add-named-exports-option
branch
from
7f93996 to
f7ef960
Compare
timse
force-pushed
the
add-named-exports-option
branch
from
ac2694b to
6e16ce9
Compare
- allow named exports via `namedExport` flag - add warnings if `namedExport` is used without camelCase option for css-loader and classes would get lost
unstubbable
suggested changes
Sep 23, 2016
| @@ -30,7 +79,7 @@ webpackConfig.module.loaders: [ | |||
| ## Example | |||
|
|
|||
| Imagine you have a file `~/my-project/src/component/MyComponent/component.scss` in your project with the following content: | |||
| @@ -54,6 +103,14 @@ declare const styles: IMyComponentScss; | |||
| export default styles; | |||
| ``` | |||
|
|
|||
| ### using `namedExport` | |||
| Using the `namedExport`-option the generated file will look as follow: | |||
There was a problem hiding this comment.
"Using the namedExport as well as the camelCase options ..."
| } else { | ||
| const [cleanedDefinitions, skippedDefinitions] = filterNonWordClasses(cssModuleKeys); | ||
| if (skippedDefinitions.length > 0 && !query.camelCase) { | ||
| console.warn(`Typings for CSS-Modules: option 'namedExport' was set but 'camelCase' for the css-loader not. |
unstubbable
suggested changes
Sep 23, 2016
| ### using `namedExport` | ||
| Using the `namedExport`-option the generated file will look as follow: | ||
| ### using `namedExport` with the `camelCase`-option | ||
| Using the namedExport as well as the camelCase options the generated file will look as follow: |
There was a problem hiding this comment.
by copy pasting, the back ticks got lost
timse
force-pushed
the
add-named-exports-option
branch
from
cf328d7 to
bc77b55
Compare
unstubbable
approved these changes
Sep 23, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add option to generate named exports instead of an interface.
TODO:
named exportsgenerator