This repository was archived by the owner on Sep 6, 2023. It is now read-only.
Processors not matched when query string casing is different #737
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to PR #728, this changes the Regex options to ignore casing within the query string, use culture invariant and explicit capture to improve performance and correctly escapes input used in the patterns.
Because processors are matched using a Regex expression, but (if matched) use the case insensitive query string (
NameValueCollection), some weird behavior can be experienced:image.jpg?width=300- resizes to 300image.jpg?Width=300- returns original image, no processing is done!image.jpg?width=300&height=200- resizes to 300x200image.jpg?Width=300&height=200- resizes to 300x200, because height is matched in the Regex and theResizeprocessor then parses the query string in a case insensitive way and can successfully get both width and height!