Fix/jigsawstack-python-audio-tts #36
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
application/json
.audio/wav
.Fix Applied
The bug stems from line 59 of jigsawstack.request.Request class, where the method
.perform()
verifies the response headers.The response headers are useful for determining the type of content received from the api as the response.
Previously, Request.perform():: line 59 would accept a response of application/json type, or raise an "parsing" error otherwise.
Fix applied: Updated the boolean check to accept
audio/wav
.Clarification: In JavaScript, a Blob represents raw binary data as a file-like object. In Python, binary responses (like audio data) are typically handled as a bytes object.
The response has to be written to a file :)
Below is an successful call: