Bugfix: track the keyID for UDP connections #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is important for applying usage limits to UDP streams. It also fixes a bug in metrics reporting, because the shared metrics are not tolerant of proxy<->target traffic that lacks a keyID.
fortuna
reviewed
Nov 5, 2020
service/udp_test.go
Outdated
| t.Errorf("Expected 2 reports, not %v", metrics.upstreamPackets) | ||
| } | ||
| for _, report := range metrics.upstreamPackets { | ||
| if report.clientProxyBytes == 0 { |
There was a problem hiding this comment.
You may want to use testify to make the assertions more concise.
fortuna
approved these changes
Nov 6, 2020
| if metrics.natEntriesAdded != 0 { | ||
| t.Error("Unexpected NAT entry on rejected packet") | ||
| metrics := sendToDiscard(payloads, onet.RequirePublicIP) | ||
| assert.Equal(t, 0, metrics.natEntriesAdded, "Unexpected NAT entry on rejected packet") |
There was a problem hiding this comment.
FYI, assert doesn't stop the execution. For that you may want require.Equal().
There was a problem hiding this comment.
I don't think we need to stop execution if this fails.
|
Could you start a v1.3.3 release after you merge? I should include this on next weeks release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is important for applying usage limits to UDP streams. It also
fixes a bug in metrics reporting, because the shared metrics are not
tolerant of proxy<->target traffic that lacks a keyID.