Remove an allocation in shadowsocksReader.Read #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, shadowsocksReader.Read passes a `[]byte` to
a method that takes an `interface{}`, triggering an
automatic cast that results in a memory allocation.
This change refactors the reader code to avoid this allocation,
with no change in behavior otherwise.
fortuna
approved these changes
Apr 13, 2020
shadowsocks/stream.go
Outdated
| // waits for incoming data and decrypts it. | ||
| // Returns an error only if sr.leftover could not be populated. | ||
| func (sr *shadowsocksReader) populateLeftover() error { | ||
| if len(sr.leftover) == 0 { |
There was a problem hiding this comment.
Return early if >0 to remove nesting and improve readability.
shadowsocks/stream.go
Outdated
| // Ensures that sr.leftover is nonempty. If leftover is empty, this method | ||
| // waits for incoming data and decrypts it. | ||
| // Returns an error only if sr.leftover could not be populated. | ||
| func (sr *shadowsocksReader) populateLeftover() error { |
There was a problem hiding this comment.
Maybe call this ensureLeftover(), since it doesn't always populate it? It will align with your comment ("Ensures....")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, shadowsocksReader.Read passes a
[]bytetoa method that takes an
interface{}, triggering anautomatic cast that results in a memory allocation.
This change refactors the reader code to avoid this allocation,
with no change in behavior otherwise.