Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename adminEmail to digitalOceanAccountName #839

Merged
merged 16 commits into from
Mar 4, 2021

Conversation

mpmcroy
Copy link
Contributor

@mpmcroy mpmcroy commented Mar 4, 2021

Renames the app-root.js DigitalOcean adminEmail to digitalOceanAccountName and simplifies outline-intro-step by removing isSignedInToDigitalOcean.

Unfortunately we still need the _compute* methods to signal to the Polymer code that an account is connected.

@mpmcroy mpmcroy requested a review from fortuna March 4, 2021 20:44
@google-cla google-cla bot added the cla: yes label Mar 4, 2021
Copy link
Collaborator

@fortuna fortuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice little cleanup.

By the way, if accounts was a list, then you wouldn't need the hidden parameter. You'd have a dom-repeat instead.

@mpmcroy mpmcroy merged commit b193850 into master Mar 4, 2021
@mpmcroy mpmcroy deleted the mpmcroy-rename-admin-email branch March 4, 2021 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants