Clean up npm dependencies #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm trying this change on Mac and it seems like the
|
|
Do you have the latest yarn? |
|
FYI, this is passing on Travis |
dborkan
approved these changes
Apr 6, 2018
There was a problem hiding this comment.
👍 change looks good.
Just FYI, this required me upgrading to the latest yarn (didn't work on 1.3.2 but it's fixed on 1.5.1). However electron-icon-maker is now failing for me (in this branch and the master branch). I think somehow upgrading yarn caused these problems on Mac (Linux still works). Maybe it's just my machine, I'm just making note here in case others have the same issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm now using Yarn workspaces, which solves the current problem where one yarn install call corrupts another.
I had to fix the ipaddr.js types with the change.