Remove unused assets and code #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we may have accidentally deleted the code that sets a timer to display the loading window. I think there's value in having it as a fallback if the main window takes too long or fails to load. Maybe call |
JonathanDCohen
force-pushed
the
cohenjon-unused-assets
branch
from
c73dd24
to
7547d1e
Compare
|
I removed the change to loadingwindow to put in #734. All else good? |
alalamav
approved these changes
Sep 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
empty_user.pngandserver_avatar.pngimages.This also removes the
LoadingWindowclass. We make one in index.ts but never actually open the window.Tested with code searching and running the app.