Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre-pulls shadowbox container base image before 'docker build' #669

Merged
merged 7 commits into from
May 30, 2020
Merged

Pre-pulls shadowbox container base image before 'docker build' #669

merged 7 commits into from
May 30, 2020

Conversation

mpmcroy
Copy link
Contributor

@mpmcroy mpmcroy commented May 28, 2020

No description provided.

@mpmcroy mpmcroy requested a review from alalamav May 29, 2020 16:44
alalamav
alalamav approved these changes May 29, 2020
View reviewed changes
Copy link
Contributor

@alalamav alalamav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how this change re-enables BuildKit and reduces duplication in the node image argument 👍

src/shadowbox/docker/build_action.sh Show resolved Hide resolved
@mpmcroy mpmcroy merged commit 5650a66 into master May 30, 2020
@sbruens sbruens deleted the mpmcroy-travis-docker-pulling-failing branch March 5, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alalamav alalamav alalamav approved these changes

@fortuna fortuna fortuna approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mpmcroy @fortuna @alalamav @googlebot