Settings page improvements #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alalamav
commented
Feb 4, 2020
•
alalamav
commented
- Replaces the data limits toggle with a dropdown in the settings page.
- Moves the experiment feedback link closer to the data limits feature.
- Replaces the metrics toggle with a checkbox.
- Re-introduces accidentally deleted behavior to watch keystrokes on the data limit input field.
fortuna
approved these changes
Feb 4, 2020
src/server_manager/web_app/app.ts
Outdated
| }); | ||
| private async setMetricsEnabled(metricsEnabled: boolean) { | ||
| try { | ||
| this.selectedServer.setMetricsEnabled(metricsEnabled); |
There was a problem hiding this comment.
Isn't this call asynchronous? Don't you need to wait?
There was a problem hiding this comment.
Good catch, fixed in 97d7c32.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.