Data limits UI #554
Data limits UI #554
Conversation
alalamav
commented
Jan 9, 2020
alalamav
commented
- Implements the user interface to configure access key data transfer limits on the Outline Manager app. The feature is currently an experiment, which is why we have a new section in the server settings.
- When data limits are enabled, the access key usage display becomes relative to the limit. Displays a tooltip on hover. Re-styles the data usage progress bar.
- Displays a notification to direct the user to the feature for existing servers upon updating the app, or when opening the app for a second time for new servers.
- Minor improvements: whitespace removal, turns nested Promise code into async/await, re-styles the help bubbles.
| paper-input, paper-textarea, paper-dropdown-menu { | ||
| --paper-input-container-focus-color: var(--primary-green); | ||
| paper-dropdown-menu { | ||
| width: 100%; |
There was a problem hiding this comment.
Why did we switch this with the definition in cloud-install-styles?
There was a problem hiding this comment.
We only want width: 100% on the feedback form dropdowns, not the one I'm adding for data limit units.
src/server_manager/web_app/app.ts
Outdated
| console.error(`Failed to set access key data limit: ${error}`); | ||
| this.appRoot.showError(this.appRoot.localize('error-set-data-limit')); | ||
| serverView.accessKeyDataLimit = this.dataLimitToDisplayDataAmount( | ||
| previousLimit || await this.computeDefaultAccessKeyDataLimit(this.selectedServer)); |
There was a problem hiding this comment.
IMO it's cleaner if we call this.computeDefaultAccessKeyDataLimit(this.selectedServer, await this.selectedServer.listAccessKeys()) here and make the second parameter required. Or alternatively get rid of the second parameter completely and call listAccessKeys() twice above
|
UI and initial feature looks great and I look forward to testing~ |
|
@JonathanDCohen, I merged your changes (63748f4). Tested that the hostname and data limits features are working as intended. Fixed a small UI issue where non-editable hostnames were getting cropped (b1e295b):
5206d2f and 33eedf1 were UI/UX fixes that resulted from a bug bash with the design team. Please take a quick look so I can merge. |
|
The strings LGTM. |
|
It looks awesome. Thank you. |
