Set -x in the integration test #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The integration test has been flaking from time to time on Travis with no obvious failures, indicating this is happening unexpectedly outside a `fail` call. `set -x` will help us diagnose when it happens again.
|
set -x makes the output extremely verbose and hard to read. Tests should be clean on success. Can we make it so that we only get extra output on failures? |
|
Changed run_action so it only outputs logs on test failure and then returns the test result |
added 2 commits
October 23, 2019 12:43
failure for easier sharing of test results. It will eventually get cleaned up whenever the tmp directory gets cleaned.
fortuna
approved these changes
Oct 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The integration test has been flaking from time to time on Travis with no obvious failures, indicating this is happening unexpectedly outside a
failcall.set -xwill help us diagnose when it happens again.