Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a few fixes to the metrics sharing code #381

Merged
merged 5 commits into from
Jan 18, 2019
Merged

a few fixes to the metrics sharing code #381

merged 5 commits into from
Jan 18, 2019

Conversation

trevj
Copy link
Contributor

@trevj trevj commented Jan 17, 2019

Just a few things I noticed while acquainting myself with this code.

@trevj trevj requested a review from fortuna January 17, 2019 21:32
fortuna
fortuna approved these changes Jan 17, 2019
View reviewed changes
Copy link
Collaborator

@fortuna fortuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup!

@trevj trevj merged commit fdca28f into master Jan 18, 2019
@trevj trevj deleted the trevj-prom-love branch January 22, 2019 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fortuna fortuna fortuna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trevj @fortuna