migrate to Electron 2.x #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alalamav
approved these changes
Aug 24, 2018
| <script src="server_manager/web_app/main.js"></script> | ||
|
|
||
| <!-- TODO: Add Outline servers to connect-src on-demand (in addition to the DigitalOcean API). --> | ||
| <meta http-equiv="Content-Security-Policy" content="default-src 'unsafe-inline' outline:; connect-src https:; frame-src https://s3.amazonaws.com/outline-vpn/"> |
There was a problem hiding this comment.
what about the other non-http protocols, i.e. macappstore://, ss://?
There was a problem hiding this comment.
I don't think they were ever relevant!
There was a problem hiding this comment.
Are you sure? The invitation page links to macappstore:// for downloading the macOS client and ss:// for importing the server when the app is already installed.
There was a problem hiding this comment.
click The iframe-d invite? I just tested and:
- Mac App Store opens without mapappstore:// in the CSP
- ss:// link doesn't open with or without macappstore:// in the CSP (in other words, it's broken as-is - I just filed an issue)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Magic mode and advanced modes seem to work fine with Electron 2; it complained about our content security policy which turned out to be completely bogus so I updated it.
BTW, I tried electron-updater 3.x but ran into compile errors. I don't think it's ready for primetime yet.