Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(metrics_server): add support for tunnel time #1527

Merged
merged 12 commits into from
Apr 4, 2024
Merged

feat(metrics_server): add support for tunnel time #1527

merged 12 commits into from
Apr 4, 2024

Conversation

sbruens
Copy link
Contributor

@sbruens sbruens commented Apr 2, 2024

Deployed to the dev service and ran the integration test.

@sbruens sbruens requested a review from fortuna April 2, 2024 19:57
@sbruens sbruens requested a review from a team as a code owner April 2, 2024 19:58
@github-actions github-actions bot added the size/L label Apr 2, 2024
daniellacosse
daniellacosse approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@daniellacosse daniellacosse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clean pr! some thoughts, but nothing blocking

src/metrics_server/connection_metrics.spec.ts Show resolved Hide resolved
src/metrics_server/connection_metrics.spec.ts Show resolved Hide resolved
src/metrics_server/connection_metrics.spec.ts Outdated Show resolved Hide resolved
src/metrics_server/connection_metrics.ts Outdated Show resolved Hide resolved
fortuna
fortuna requested changes Apr 3, 2024
View reviewed changes
src/metrics_server/README.md Outdated Show resolved Hide resolved
src/metrics_server/connection_metrics.spec.ts Outdated Show resolved Hide resolved
src/metrics_server/connection_metrics.ts Outdated Show resolved Hide resolved
src/metrics_server/test_integration.action.sh Show resolved Hide resolved
src/metrics_server/connection_metrics.ts Show resolved Hide resolved
src/metrics_server/connection_metrics.ts Outdated Show resolved Hide resolved
@sbruens sbruens requested a review from fortuna April 4, 2024 13:13
fortuna
fortuna approved these changes Apr 4, 2024
View reviewed changes
Copy link
Collaborator

@fortuna fortuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is shaping up nicely!

src/metrics_server/connection_metrics.spec.ts Outdated Show resolved Hide resolved
src/metrics_server/connection_metrics.ts Show resolved Hide resolved
@sbruens sbruens merged commit 571be90 into master Apr 4, 2024
10 checks passed
@sbruens sbruens deleted the sbruens/tunnel-time-metrics branch April 4, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniellacosse daniellacosse daniellacosse approved these changes

@fortuna fortuna fortuna approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sbruens @fortuna @daniellacosse