Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: delete manager and update server_manager/README.md #1511

Merged
merged 9 commits into from
Feb 22, 2024
Merged

chore: delete manager and update server_manager/README.md #1511

merged 9 commits into from
Feb 22, 2024

Conversation

daniellacosse
Copy link
Contributor

No description provided.

@daniellacosse daniellacosse requested review from fortuna and a team as code owners February 21, 2024 21:37
@daniellacosse daniellacosse changed the title chore(server_manager): delete manager and update server_manager/README.md chore(manager): delete manager and update server_manager/README.md Feb 21, 2024
@daniellacosse daniellacosse changed the title chore(manager): delete manager and update server_manager/README.md chore: delete manager and update server_manager/README.md Feb 21, 2024
fortuna
fortuna requested changes Feb 21, 2024
View reviewed changes
Copy link
Collaborator

@fortuna fortuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the root README and the references in

outline-server/src/shadowbox/README.md

Line 15 in a62b25b

sudo bash -c "$(wget -qO- https://raw.githubusercontent.com/Jigsaw-Code/outline-server/master/src/server_manager/install_scripts/install_server.sh)"

src/server_manager/README.md Outdated Show resolved Hide resolved
src/server_manager/README.md Show resolved Hide resolved
@fortuna
Copy link
Collaborator

fortuna commented Feb 21, 2024

We also need to fix the Karma issue from CI:

/home/runner/work/outline-server/outline-server/src/sentry_webhook/test.action.sh: line 24: karma: command not found

daniellacosse and others added 2 commits February 21, 2024 16:54
@daniellacosse @fortuna
Update src/server_manager/README.md
49b5df9 
Co-authored-by: Vinicius Fortuna <fortuna@users.noreply.github.com>
@daniellacosse
Update README.md
775ccc6
fortuna
fortuna reviewed Feb 21, 2024
View reviewed changes
Copy link
Collaborator

@fortuna fortuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noting that Karma still needs to be fixed

@daniellacosse
Copy link
Contributor Author

Just noting that Karma still needs to be fixed

Done!

fortuna
fortuna approved these changes Feb 22, 2024
View reviewed changes
Copy link
Collaborator

@fortuna fortuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup!

@daniellacosse daniellacosse merged commit cd5f917 into master Feb 22, 2024
10 checks passed
@sbruens sbruens mentioned this pull request Jul 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fortuna fortuna fortuna approved these changes

Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daniellacosse @fortuna