Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(manager/electron): adds hardened runtime and notarization options to the MacOS build #1508

Merged
merged 1 commit into from
Feb 13, 2024
Merged

fix(manager/electron): adds hardened runtime and notarization options to the MacOS build #1508

merged 1 commit into from
Feb 13, 2024

Conversation

daniellacosse
Copy link
Contributor

@daniellacosse daniellacosse commented Feb 13, 2024 •
edited
Loading

context provided here: #1508 (comment)

@daniellacosse daniellacosse requested a review from a team as a code owner February 13, 2024 14:53
sbruens
sbruens approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@sbruens sbruens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add some more details to the PR to explain the "why" of this change? What changed since our last successfully notarized build that these changes were necessary? Would be helpful to have that record for future reference.

src/server_manager/electron_app/release/macos.entitlements
@@ -4,6 +4,8 @@
<dict>
<key>com.apple.security.cs.allow-unsigned-executable-memory</key>
<true/>
<key>com.apple.security.cs.allow-jit</key>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious. Why was this needed?

@daniellacosse
Copy link
Contributor Author

daniellacosse commented Feb 13, 2024 •
edited
Loading

Could you add some more details to the PR to explain the "why" of this change? What changed since our last successfully notarized build that these changes were necessary? Would be helpful to have that record for future reference.

Uhhh Gemini Advanced, can you help me out??

JK - I don't fully know? It's one of two things:

  1. The api of electron/electron-builder changed and now notary options are passed through via notarize - this is more likely.
  2. recent changes to apple platforms require we "harden" the runtime, which requires additional entitlements (see this doc I found: https://kilianvalkhof.com/2019/electron/notarizing-your-electron-application/) and I figured, might as well do this too

@daniellacosse daniellacosse merged commit 06646f7 into master Feb 13, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbruens sbruens sbruens approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daniellacosse @sbruens