Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(server): extend key creation API to allow specifying a port #1505

Merged
merged 7 commits into from
Feb 7, 2024
Merged

feat(server): extend key creation API to allow specifying a port #1505

merged 7 commits into from
Feb 7, 2024

Commits on Feb 6, 2024

  1. feat(server): extend key creation API to allow specifying a port

    @sbruens
    sbruens committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    711fc5b View commit details
    Browse the repository at this point in the history

  2. Use validateNumberParam in setPortForNewAccessKey.

    @sbruens
    sbruens committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    9c5a263 View commit details
    Browse the repository at this point in the history

  3. Only check if the port is valid if it was specified.

    @sbruens
    sbruens committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    7b96360 View commit details
    Browse the repository at this point in the history

  4. Undo the removal of use of Promise.all(...).

    @sbruens
    sbruens committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    8e13a9d View commit details
    Browse the repository at this point in the history

  5. Fix tests.

    @sbruens
    sbruens committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    24f9e98 View commit details
    Browse the repository at this point in the history

  6. Only run validation if parameters are provided.

    @sbruens
    sbruens committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    73cd986 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2024

  1. Correct types for API validation methods where undefined is a possi… 

    …ble return type.
    @sbruens
    sbruens committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    cc91403 View commit details
    Browse the repository at this point in the history