chore(manager): cleanup and fix Manager build #1497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fortuna
changed the title
| @@ -0,0 +1,103 @@ | |||
| #!/bin/bash -eu | |||
There was a problem hiding this comment.
Would you be willing to write this as a node file? Just so we're moving towards cross-platform development instead of away from it.
There was a problem hiding this comment.
Not at this point. The effort is not justified. We already have Linux+macOS cross-platform development, we don't develop the Manager on Windows.
I just want to move forward and go back to the SDK. I did remove over 112 net lines in this PR though, so I claim the state is better.
There was a problem hiding this comment.
Mm, alright. Thanks for doing this!
daniellacosse
approved these changes
Feb 2, 2024
| @@ -0,0 +1,103 @@ | |||
| #!/bin/bash -eu | |||
There was a problem hiding this comment.
Mm, alright. Thanks for doing this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
packageaction and remove packaging logic from build. This makes start take < 1/5 of the time.script/folder. The scripts were not used, or were folded into the package script.BUILD_ENV, which I renamed toWEBPACK_MODE.