fix: link "Help" directly to support.getoutline.org #1490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbruens
approved these changes
Jan 31, 2024
jyyi1
reviewed
Jan 31, 2024
| @@ -409,7 +409,7 @@ export class AppRoot extends polymerElementWithLocalize { | |||
| </if-messages> | |||
| <span on-tap="maybeCloseDrawer"><a href="https://support.getoutline.org/s/article/Data-collection">[[localize('nav-data-collection')]]</a></span> | |||
| <span on-tap="submitFeedbackTapped">[[localize('nav-feedback')]]</span> | |||
| <span on-tap="maybeCloseDrawer"><a href="https://s3.amazonaws.com/outline-vpn/index.html#/en/support/">[[localize('nav-help')]]</a></span> | |||
| <span on-tap="maybeCloseDrawer"><a href="https://support.getoutline.org/">[[localize('nav-help')]]</a></span> | |||
There was a problem hiding this comment.
We are using s3.amazonaws.com to bypass the block of getoutline.org domain. Is it the expected behavior to switch to getoutline.org?
There was a problem hiding this comment.
Do we care about that here? This is the manager.
It is possible though that I broke it when I updated the mirror?
There was a problem hiding this comment.
Ah, i guess manager should be good! Thanks.
jyyi1
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.