Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(manager): link to Management API Documentation next to the Management API Endpoint #1486

Merged
merged 2 commits into from
Jan 29, 2024
Merged

feat(manager): link to Management API Documentation next to the Management API Endpoint #1486

merged 2 commits into from
Jan 29, 2024

Conversation

daniellacosse
Copy link
Contributor

@daniellacosse daniellacosse commented Jan 29, 2024 •
edited
Loading

Screenshot 2024-01-29 at 3 26 05 PM

@daniellacosse daniellacosse marked this pull request as ready for review January 29, 2024 20:28
@daniellacosse daniellacosse requested a review from a team as a code owner January 29, 2024 20:28
jyyi1
jyyi1 reviewed Jan 29, 2024
View reviewed changes
Copy link
Contributor

@jyyi1 jyyi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we care about these GitHub lint warnings?

image

@daniellacosse
Copy link
Contributor Author

Do we care about these GitHub lint warnings?

image

No, it seems the Github linter doesn't know how to handle typescript decorators, lol

jyyi1
jyyi1 approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@jyyi1 jyyi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Thanks!

@daniellacosse daniellacosse merged commit 33de2a9 into master Jan 29, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyyi1 jyyi1 jyyi1 approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daniellacosse @jyyi1