Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(manager/electron): replace turned down OmahaProxy with ChromiumDash #1462

Merged
merged 5 commits into from
Dec 11, 2023
Merged

fix(manager/electron): replace turned down OmahaProxy with ChromiumDash #1462

merged 5 commits into from
Dec 11, 2023

Conversation

sbruens
Copy link
Contributor

@sbruens sbruens commented Dec 11, 2023 •
edited
Loading

This service is turned down. See https://groups.google.com/a/chromium.org/g/chromium-dev/c/uH-nFrOLWtE.

It's currently returning:

*** Service Permanently Offline ***

OmahaProxy has been turned down.
Please migrate to <https://chromiumdash.appspot.com>.

ChromiumDash is meant to replace this functionality.

@sbruens sbruens requested a review from a team as a code owner December 11, 2023 21:14
@sbruens sbruens changed the title fix(server_manager): replace turned down Omahaproxy with Chromium Dash fix(server_manager): replace turned down OmahaProxy with Chromium Dash Dec 11, 2023
@sbruens sbruens mentioned this pull request Dec 11, 2023
Merged
@sbruens sbruens changed the title fix(server_manager): replace turned down OmahaProxy with Chromium Dash fix(server_manager): replace turned down OmahaProxy with ChromiumDash Dec 11, 2023
@sbruens sbruens changed the title fix(server_manager): replace turned down OmahaProxy with ChromiumDash fix(manager/electron): replace turned down OmahaProxy with ChromiumDash Dec 11, 2023
daniellacosse
daniellacosse approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@daniellacosse daniellacosse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol int does not equal string

@sbruens sbruens merged commit b878904 into master Dec 11, 2023
13 checks passed
@sbruens sbruens deleted the sbruens/omahaproxy branch December 11, 2023 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniellacosse daniellacosse daniellacosse approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbruens @daniellacosse