Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade restify to v11 to support lts/hydrogen #1423

Merged
merged 2 commits into from
Oct 11, 2023
Merged

chore: upgrade restify to v11 to support lts/hydrogen #1423

merged 2 commits into from
Oct 11, 2023

Conversation

daniellacosse
Copy link
Contributor

No description provided.

@daniellacosse daniellacosse requested review from fortuna and a team as code owners October 11, 2023 10:59
@daniellacosse daniellacosse marked this pull request as draft October 11, 2023 10:59
@daniellacosse daniellacosse changed the title chore: upgrade restify to support lts/hydrogen chore: upgrade restify to v11 to support lts/hydrogen Oct 11, 2023
@daniellacosse daniellacosse mentioned this pull request Oct 11, 2023
Merged
3 tasks
@daniellacosse daniellacosse added the dependencies Pull requests that update a dependency file label Oct 11, 2023
@daniellacosse daniellacosse marked this pull request as ready for review October 11, 2023 14:53
@daniellacosse
Copy link
Contributor Author

daniellacosse commented Oct 11, 2023 •
edited
Loading

@fortuna can we assume shadowbox works if the integration tests are passing? What did you anticipate breaking?

fortuna
fortuna approved these changes Oct 11, 2023
View reviewed changes
Copy link
Collaborator

@fortuna fortuna left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's ok if the integration test pass. We should be extra careful with the server release though, and test using the Manager to make sure there's no issue with CORS.

@daniellacosse daniellacosse merged commit aa56b08 into master Oct 11, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fortuna fortuna fortuna approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daniellacosse @fortuna