feat(server): add optional name/limit/password props for createNewAccessKey method #1273

murka · 2023-01-24T18:51:58Z

No description provided.

fortuna · 2023-02-06T18:50:44Z

@murka Could you add a bit of background on why you need this change?
What are you trying to accomplish?

murka · 2023-04-17T20:48:00Z

@fortuna, I would like to add options when creating a key, right now it takes three steps to create a key, change the name and add restrictions.

…atalimit

murka · 2023-07-27T21:54:06Z

@fortuna This PR is ready to merge! The PR is not blocking compatibility for previous server versions, because new props is optional.

https://github.com/murka/outline-server/actions/runs/5685731607

vatrubin · 2023-09-05T21:01:09Z

@murka Could you add a password field? I would like to synchronize passwords between several servers, but this cannot be done through the API.

murka · 2023-09-11T13:30:12Z

@vatrubin, no, it's not completion for this PR, password will be automatically generated for each accessKey. You can sync opt file storage for between servers.

murka · 2023-12-11T14:42:40Z

@fortuna @daniellacosse, any updates?

Feat password create new access key

src/shadowbox/model/access_key.ts

src/shadowbox/server/manager_service.ts

Co-authored-by: Vinicius Fortuna <fortuna@users.noreply.github.com>

src/shadowbox/server/manager_service.ts

Co-authored-by: Vinicius Fortuna <fortuna@users.noreply.github.com>

fortuna

Thanks for fixing the test. I realize that one issue was not addressed.

src/shadowbox/server/manager_service.ts

fortuna · 2024-01-11T04:49:35Z

Oh, there are still tests failing when you run npm run action shadowbox/test.
See https://github.com/Jigsaw-Code/outline-server/actions/runs/7469550377/job/20371104279?pr=1273

murka · 2024-01-11T19:07:57Z

@fortuna, all jobs is succeed: https://github.com/murka/outline-server/actions/runs/7369417871

fortuna

Thanks a lot for the contribution and patience!

jadolg · 2024-02-05T20:01:17Z

src/shadowbox/server/api.yml

                method:
                  type: string
+                password:
+                  type: string
+                port:


I think port was not implemented as part of this PR

@jadolg I think you are right. You can still set the port for new access keys if you want to do that, but we should add it to the key creation API as well.

I'll send a PR to add this.

Please also review the PUT method. I think it's wired to the same method so it should not work either but the docs claim it does.

even though it was added to the API spec, the parameter is missing from implementation. See Jigsaw-Code/outline-server#1273

murka added 3 commits January 24, 2023 20:58

feat: add optional name and dataLimit prop for createNewAccessKey method

6f1ae95

fix: add error catching

9a5b0e6

test: name and limit/dataLimit optional props

1ab3d5f

murka requested a review from fortuna as a code owner January 24, 2023 18:51

murka changed the title ~~feat: add optional name and limit props for createNewAccessKey method~~ feat(shadowbox): add optional name and limit props for createNewAccessKey method Jan 24, 2023

murka marked this pull request as draft January 26, 2023 15:01

murka changed the title ~~feat(shadowbox): add optional name and limit props for createNewAccessKey method~~ feat(server): add optional name and limit props for createNewAccessKey method Jan 26, 2023

feat: use interface instead of params

e2c45d3

murka marked this pull request as ready for review January 26, 2023 19:46

fix: validate only if limit is defined

09f88bf

murka marked this pull request as draft February 4, 2023 08:02

murka added 3 commits March 8, 2023 13:58

ci: fix query-filters

f34c841

ci: fix codeql workflow

9512ca3

ci(codeql): security and quality queries

f39b453

murka and others added 3 commits July 20, 2023 03:00

Merge branch 'Jigsaw-Code:master' into feat-createNewAccessKey-name-d…

baf0843

…atalimit

Merge branch 'Jigsaw-Code:master' into master

7384a91

Merge branch 'feat-createNewAccessKey-name-datalimit'

e29d82f

murka marked this pull request as ready for review July 19, 2023 22:03

murka added 3 commits July 28, 2023 01:53

Merge branch 'feat-createNewAccessKey-name-datalimit'

032b0fd

fix(shadowbox): use optional chaining for check params defined

62eab04

fix(shadowbox): check if encryptionMethod is empty string

9c295b4

murka and others added 3 commits December 26, 2023 21:31

Merge branch 'Jigsaw-Code:master' into master

a5e45b2

feat(shadowbox): provide the password prop on createNewAccessKey

22554db

Merge pull request #1 from murka/feat-password-createNewAccessKey

aacd645

Feat password create new access key

murka requested a review from a team as a code owner December 30, 2023 20:01

murka added 7 commits December 31, 2023 01:10

fix: dataLimit validation function to get the types of object

476bd23

fix: validatePassword prop maybe is non-string

d024091

fix: revert removed prop

455991a

style: use condition chain for check prop

ada6d38

fix: params check for dataLimit prop

36c6a0c

fix: remove double password prop validation

f0fc931

docs: add properties for api schema

21fb92c

murka requested a review from fortuna December 30, 2023 21:38

fortuna requested changes Jan 2, 2024

View reviewed changes

src/shadowbox/model/access_key.ts Show resolved Hide resolved

src/shadowbox/server/manager_service.ts Outdated Show resolved Hide resolved

src/shadowbox/server/manager_service.ts Outdated Show resolved Hide resolved

Update manager_service.ts

09cda03

Co-authored-by: Vinicius Fortuna <fortuna@users.noreply.github.com>

murka mentioned this pull request Jan 5, 2024

PoC: non-increment unique keyId #1468

Closed

fortuna requested changes Jan 9, 2024

View reviewed changes

src/shadowbox/server/manager_service.ts Show resolved Hide resolved

src/shadowbox/server/manager_service.ts Outdated Show resolved Hide resolved

Update src/shadowbox/server/manager_service.ts

ab03340

Co-authored-by: Vinicius Fortuna <fortuna@users.noreply.github.com>

sbruens mentioned this pull request Jan 11, 2024

feat(server): add optional id parameter to createNewAccessKey method #1473

Merged

fortuna reviewed Jan 11, 2024

View reviewed changes

src/shadowbox/server/manager_service.ts Outdated Show resolved Hide resolved

murka added 5 commits January 11, 2024 22:57

perf(shadownbox): remove checking password bytes lenght

727bcd0

refactor: validating params system

6a5b8c3

refactor: validate unknown string params

c92f489

chore: remove unusable test

d53542d

fix: skip to validating undefined param

9afefff

murka requested a review from fortuna January 11, 2024 19:13

fortuna approved these changes Jan 12, 2024

View reviewed changes

fortuna merged commit 57a30a2 into Jigsaw-Code:master Jan 12, 2024
14 checks passed

murka deleted the feat-createNewAccessKey-name-datalimit branch January 12, 2024 21:01

jadolg reviewed Feb 5, 2024

View reviewed changes

jadolg added a commit to jadolg/outline-vpn-api that referenced this pull request Feb 5, 2024

Remove port parameter

6e12c00

even though it was added to the API spec, the parameter is missing from implementation. See Jigsaw-Code/outline-server#1273

sbruens mentioned this pull request Feb 6, 2024

feat(server): extend key creation API to allow specifying a port #1505

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(server): add optional name/limit/password props for createNewAccessKey method #1273

feat(server): add optional name/limit/password props for createNewAccessKey method #1273

murka commented Jan 24, 2023

fortuna commented Feb 6, 2023

murka commented Apr 17, 2023 •

edited

Loading

murka commented Jul 27, 2023 •

edited

Loading

vatrubin commented Sep 5, 2023

murka commented Sep 11, 2023 •

edited

Loading

murka commented Dec 11, 2023

fortuna left a comment

fortuna commented Jan 11, 2024

murka commented Jan 11, 2024

fortuna left a comment

jadolg Feb 5, 2024

fortuna Feb 5, 2024

sbruens Feb 5, 2024

jadolg Feb 5, 2024

feat(server): add optional name/limit/password props for createNewAccessKey method #1273

feat(server): add optional name/limit/password props for createNewAccessKey method #1273

Conversation

murka commented Jan 24, 2023

fortuna commented Feb 6, 2023

murka commented Apr 17, 2023 • edited Loading

murka commented Jul 27, 2023 • edited Loading

vatrubin commented Sep 5, 2023

murka commented Sep 11, 2023 • edited Loading

murka commented Dec 11, 2023

fortuna left a comment

Choose a reason for hiding this comment

fortuna commented Jan 11, 2024

murka commented Jan 11, 2024

fortuna left a comment

Choose a reason for hiding this comment

jadolg Feb 5, 2024

Choose a reason for hiding this comment

fortuna Feb 5, 2024

Choose a reason for hiding this comment

sbruens Feb 5, 2024

Choose a reason for hiding this comment

jadolg Feb 5, 2024

Choose a reason for hiding this comment

murka commented Apr 17, 2023 •

edited

Loading

murka commented Jul 27, 2023 •

edited

Loading

murka commented Sep 11, 2023 •

edited

Loading