Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove broken feedback form #1252

Merged
merged 2 commits into from
Dec 16, 2022
Merged

fix: remove broken feedback form #1252

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
34ff94a
remove feedback
daniellacosse Dec 15, 2022
8628488
switch to comment
daniellacosse Dec 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/server_manager/web_app/ui_components/app-root.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,7 +392,8 @@ export class AppRoot extends polymerElementWithLocalize {
<!-- Links section -->
<paper-listbox>
<span on-tap="maybeCloseDrawer"><a href="https://s3.amazonaws.com/outline-vpn/index.html#/en/support/dataCollection">[[localize('nav-data-collection')]]</a></span>
<span on-tap="submitFeedbackTapped">[[localize('nav-feedback')]]</span>
Comment on lines 394 to -395
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's comment it out instead and add a comment to restore when it's fixed.

<!-- TODO(daniellacosse): restore this once the feedback form is fixed -->
<!-- <span on-tap="submitFeedbackTapped">[[localize('nav-feedback')]]</span> -->
<span on-tap="maybeCloseDrawer"><a href="https://s3.amazonaws.com/outline-vpn/index.html#/en/support/">[[localize('nav-help')]]</a></span>
<span on-tap="aboutTapped">[[localize('nav-about')]]</span>
<div id="links-footer">
Expand Down