Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "refactor(manager): replace share s3 flow with self-contained instructions" #1166

Merged
merged 1 commit into from
Oct 5, 2022
Merged

Revert "refactor(manager): replace share s3 flow with self-contained instructions" #1166

merged 1 commit into from
Oct 5, 2022

Conversation

daniellacosse
Copy link
Contributor

Reverts #1133

@daniellacosse daniellacosse requested review from a team as code owners September 27, 2022 18:31
jyyi1
jyyi1 approved these changes Sep 28, 2022
View reviewed changes
Copy link
Contributor

@jyyi1 jyyi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevindamm-jigsaw
Copy link
Contributor

LGTM does this need translations to be reverted too?

@daniellacosse
Copy link
Contributor Author

LGTM does this need translations to be reverted too?

Ah, yes - It should be a recent PR. Double check that that's a clean revert, too.

@kevindamm-jigsaw
Copy link
Contributor

kevindamm-jigsaw commented Sep 28, 2022 •
edited
Loading

yeah, I think it was #1158

there was another translation change for the price update but I think that doesn't need to be reverted (and was before the above PR so shouldn't conflict, either)

@daniellacosse
Copy link
Contributor Author

yeah, I think it was #1158

there was another translation change for the price update but I think that doesn't need to be reverted (and was before the above PR so shouldn't conflict, either)

Awesome, make it so

@daniellacosse daniellacosse merged commit 6cbf4ed into master Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyyi1 jyyi1 jyyi1 approved these changes

@kevindamm-jigsaw kevindamm-jigsaw kevindamm-jigsaw approved these changes

@cjhenck cjhenck Awaiting requested review from cjhenck cjhenck was automatically assigned from Jigsaw-Code/outline-strings-owners

@fortuna fortuna Awaiting requested review from fortuna

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daniellacosse @kevindamm-jigsaw @jyyi1