Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(manager): removes special case for manager connection key #1138

Merged
merged 4 commits into from
Aug 16, 2022
Merged

fix(manager): removes special case for manager connection key #1138

merged 4 commits into from
Aug 16, 2022

Conversation

daniellacosse
Copy link
Contributor

@daniellacosse daniellacosse commented Aug 8, 2022 •
edited
Loading

@daniellacosse daniellacosse requested a review from a team as a code owner August 8, 2022 16:56
@github-actions github-actions bot added the size/M label Aug 8, 2022
@daniellacosse daniellacosse requested a review from a team as a code owner August 8, 2022 16:59
@daniellacosse daniellacosse requested review from cjhenck and fortuna and removed request for a team and cjhenck August 8, 2022 16:59
@daniellacosse
Copy link
Contributor Author

What should I test to confirm this doesn't break anything?

fortuna
fortuna reviewed Aug 11, 2022
View reviewed changes
Copy link
Collaborator

@fortuna fortuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For testing, you can make sue the key 0 is working. Also try adding a few keys, then delete key 0 to make sure nothing weird happens.

@daniellacosse
Copy link
Contributor Author

I guess so, but it should only ever show on key 0, if it wasn't dismissed before.

Here's it now:

Screen Shot 2022-08-15 at 16 56 56

@daniellacosse daniellacosse merged commit 3b0e615 into master Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fortuna fortuna fortuna approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daniellacosse @fortuna