fix: remove outdated RELEASES_REPOSITORY #1119
Conversation
| buildFlags = [ | ||
| ...buildFlags, | ||
| '--config.generateUpdatesFilesForAllChannels=true', | ||
| '--config.publish.provider=generic', | ||
| `--config.publish.url=${process.env.RELEASES_REPOSITORY}`, | ||
| '--config.publish.url=https://raw.githubusercontent.com/Jigsaw-Code/outline-releases/master/manager/', |
There was a problem hiding this comment.
@jyyi1 with Git LFS this changes - what is the new URL?
| buildFlags = [ | ||
| ...buildFlags, | ||
| '--config.generateUpdatesFilesForAllChannels=true', | ||
| '--config.publish.provider=generic', | ||
| `--config.publish.url=${process.env.RELEASES_REPOSITORY}`, | ||
| '--config.publish.provider=github', |
There was a problem hiding this comment.
I think this has to be reverted to generic, since we are not using github releases: https://www.electron.build/configuration/publish.html
There was a problem hiding this comment.
seems this was a copy paste error from the S3 code in the client - https://www.electron.build/configuration/publish.html provider should be github?
There was a problem hiding this comment.
We are specifying the URL. It should be generic. That's what we were using before: https://github.com/Jigsaw-Code/outline-server/blob/a19e0a0090ccd570697223b4f89ad62f82025a6d/src/server_manager/electron_app/release_windows_action.sh
There was a problem hiding this comment.
ah seems i didn't read enough. reverting.
| buildFlags = [ | ||
| ...buildFlags, | ||
| '--config.generateUpdatesFilesForAllChannels=true', | ||
| '--config.publish.provider=generic', | ||
| `--config.publish.url=${process.env.RELEASES_REPOSITORY}`, | ||
| '--config.publish.provider=github', |
There was a problem hiding this comment.
We are specifying the URL. It should be generic. That's what we were using before: https://github.com/Jigsaw-Code/outline-server/blob/a19e0a0090ccd570697223b4f89ad62f82025a6d/src/server_manager/electron_app/release_windows_action.sh
No description provided.