fix(manager): specify a higher per_page for DigitalOcean API call #1113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… call to get droplets.
…ets' DO API call to use 100 as well. 100 is the tested limit, and a sane default until proper pagination
Hi @fortuna, I've reviewed recommendations and actioned. Let me know if that's enough for now, and to leave pagination support as iteration. Thanks |
fortuna
approved these changes
Aug 24, 2022
|
For some reason the status seems to be stuck... |
|
@cgarvey you may need to pull master to trigger the tests again. |
Done, sorry I missed the comment. Latest master merged in now. Let me know if there's anything else I can do to help |
fortuna
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default (if not specified) is 20. Increase to 100 (tested).
Fixes #999.