-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
the traffic limit isn't respected when set to zero before the first connection #1515
Comments
@whlack, thanks for the issue. However, I'm experiencing difficulty in replicating the scenario you've described. Could you please provide a more detailed account or enhance the step-by-step instructions for reproducing the problem? Your assistance will help us address the issue more effectively. |
|
I've been having the same problem for a very long time, starting around version 1.8.0. But I do not reset the limit; access using keys with a zero limit is terminated automatically when traffic accumulates in the range of 300 - 350 MB, provided that the client reconnects at this moment. Up to 300 MB reconnections are not blocked. |
I'm facing the same problem. Version 1.8.1. When I create a new key with a data limit, it works as if there is no limit. I tried to install it manually in the Outline manager, and via the API. The result is the same. Has anyone come up with a workaround? |
I sent a merge request which targets this issue, hopefully it will be available in the next update. But if you want it now, there is a quick surgical way to fix it. it also fixes @fourclever issue which is an hour delay:
|
* Fix isOverDataLimit logic to stop allowing 0 traffic byte issue #1515 This if statement is just wrong and doesn't block access when traffic limit is set to 0 byte. This one character fixes it. Now if we create a new access key, set the limit to 0 before first usage, the client no longer will be able to connect. * Rename `isOverDataLimit` to `reachedDataLimit`. * Add a test case to prevent regression. * Rename old variable. * Update comment now that variable has changed meaning slightly. Co-authored-by: Vinicius Fortuna <fortuna@users.noreply.github.com> --------- Co-authored-by: sbruens <sbruens@users.noreply.github.com> Co-authored-by: Vinicius Fortuna <fortuna@users.noreply.github.com>
When we create an access key, and set traffic limit to 0B before first connection, we can connect and use this key as long as we want. But if we set traffic limit to 0B after first connection, all works fine.
The text was updated successfully, but these errors were encountered: