fix(client): protect against UDP panic #2371
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyyi1
approved these changes
Feb 7, 2025
Contributor
jyyi1
left a comment
jyyi1
left a comment
There was a problem hiding this comment.
Sounds like a workaround, maybe have a todo comment mentioning the ideal fix?
| func (h *udpHandler) ReceiveTo(tunConn core.UDPConn, data []byte, destAddr *net.UDPAddr) (err error) { | ||
| defer func() { | ||
| if r := recover(); r != nil { | ||
| slog.Error("Panic in UDP handler", "err", r) |
Contributor
There was a problem hiding this comment.
Will this log be collected by Sentry?
Collaborator
Author
|
Humm... I'm not 100% convinced about this PR. If we recover from panic, the proxyConn may be in a corrupted state, so future Writes will likely panic as well. Possibly the reads and close too. We could try to discard them, but Close is needed for cleanup. Needs more thought. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.