Skip to content

Fix model_override typos #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jischein wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix model_override typos #1

jischein wants to merge 2 commits into from

Conversation

@jischein
Copy link

@jischein jischein commented Sep 1, 2024

get_config in sglang.srt.hf_transformer_utils was being passed incorrect arguments do to a typo; this PR addresses that typo

Motivation

Modifications

Checklist

  • Format your code according to the Contributor Guide.
  • Add unit tests as outlined in the Contributor Guide.
  • Update documentation as needed, including docstrings or example tutorials.

@jischein jischein mentioned this pull request Sep 1, 2024
Closed
4 tasks
@JianyuZhan JianyuZhan force-pushed the main branch 3 times, most recently from 688cb2c to 7df54ad Compare September 3, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jischein @JianyuZhan