Rename remove_value() -> omit_list_value()

Co-Authored-By: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
JiachenSmith · Sep 20, 2023 · ebd4a4f · ebd4a4f
1 parent 222e761
commit ebd4a4f
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 10 deletions.
diff --git a/piptools/resolver.py b/piptools/resolver.py
@@ -46,7 +46,7 @@
     is_url_requirement,
     key_from_ireq,
     key_from_req,
-    remove_value,
+    omit_list_value,
     strip_extras,
 )
 
@@ -236,7 +236,7 @@ def __init__(
             raise PipToolsError("Legacy resolver deprecated feature must be enabled.")
 
         # Make sure there is no enabled 2020-resolver
-        options.features_enabled = remove_value(
+        options.features_enabled = omit_list_value(
             options.features_enabled, "2020-resolver"
         )
 
@@ -534,7 +534,7 @@ def __init__(
         self._constraints_map = {key_from_ireq(ireq): ireq for ireq in constraints}
 
         # Make sure there is no enabled legacy resolver
-        options.deprecated_features_enabled = remove_value(
+        options.deprecated_features_enabled = omit_list_value(
             options.deprecated_features_enabled, "legacy-resolver"
         )
 

diff --git a/piptools/utils.py b/piptools/utils.py
@@ -444,10 +444,8 @@ def get_sys_path_for_python_executable(python_executable: str) -> List[str]:
     return [os.path.abspath(path) for path in paths]
 
 
-def remove_value(lst: List[_T], value: _T) -> List[_T]:
-    """
-    Returns new list without a given value.
-    """
+def omit_list_value(lst: List[_T], value: _T) -> List[_T]:
+    """Produce a new list with a given value skipped."""
     return [item for item in lst if item != value]
 
 

diff --git a/piptools/writer.py b/piptools/writer.py
@@ -293,9 +293,7 @@ def _format_requirement(
         if ireq.comes_from:
             required_by.add(_comes_from_as_string(ireq.comes_from))
 
-        if hasattr(ireq, "_required_by"):
-            for name in ireq._required_by:
-                required_by.add(name)
+        required_by |= set(getattr(ireq, "_required_by", set()))
 
         if required_by:
             if self.annotation_style == "split":