Skip to content

Enlarge dG limits #361

Description

@Shakrim

Hi Jochem,

would be possible to enlarge dG_limits in make_dict function form {"start": 10, "end": 50} to {"start": -10, "end": 50}. I wanted to simulate the calculation of the D-uptake of a peptide, given the parameters of the Linderstrøm-lang model in peptide app. But hard limit is 10-50 KJ/mol. We have initial dGs calculated from previous experiment having negative values. Shall I create pull request? I push the branch for review? Thank you for considering.

Activity

  1. Jhsmit commented on Nov 13, 2024

    @Jhsmit
    Owner

    Hi, yes if you have code for PR that would be very welcome

  2. Shakrim commented on Nov 15, 2024

    @Shakrim
    Author

    Could you grant me access to be able push my branch for PR?

  3. Jhsmit commented on Nov 15, 2024

    @Jhsmit
    Owner

    If you have a fork of PyHDX then you should be able to make a PR from there
    In short the procedure is 1) make a fork 2) clone the fork, make a branch and commit your changes to the branch 3) push your changes to your fork and then make a pull request upstream (on this repo)

    There is more information here:
    https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/getting-started

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions