[repo-assist] perf(query): normalize search terms once per query - #2928
Draft
github-actions[bot] wants to merge 1 commit into
Draft
[repo-assist] perf(query): normalize search terms once per query#2928github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This is an automated change from Repo Assist.
Summary
Normalize multi-term search strings once before filtering AUR results instead of lowercasing each term for every package. This removes repeated allocations and work from the result loop while preserving matching behavior.
Rationale
AUR search filtering can process many results, so per-result term normalization scales unnecessarily with the number of packages. Precomputing the normalized terms makes the hot path perform only the package-field normalization and containment checks.
Trade-offs
The change adds one small normalized-term slice per search and keeps the existing filtering semantics unchanged.
Test Status
go test ./pkg/query -count=1passed.make buildpassed.make testis blocked by the environment: missinglibalpm.so,pacman-conf, and the Gocovdatatool.make lintis blocked becausegolangci-lintis unavailable.Repo Assist leaves this draft for maintainer review.
Warning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
awmgmcpgSee Network Configuration for more information.
Add this agentic workflow to your repo
To install this agentic workflow, run