Introduce vsync-based and overcommitment throttling to metal redrawer on macOS #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add overcommitment prevention mechanism * Replace hardcoded value with CAMetalLayer property * Update skiko/src/awtMain/objectiveC/macos/MetalContextHandler.mm Co-authored-by: Igor Demin <igordmn@users.noreply.github.com> --------- Co-authored-by: Igor Demin <igordmn@users.noreply.github.com>
elijah-semyonov
changed the title
igordmn
reviewed
Jul 7, 2023
| NSScreen *_displayLinkScreen; | ||
| CVDisplayLinkRef _displayLink; | ||
| NSConditionLock *_vsyncConditionLock; | ||
| volatile atomic_bool _displayLinkOk; |
There was a problem hiding this comment.
It seems we can get rid of this variable. Check this PR, is everything ok in it?
igordmn
reviewed
Jul 7, 2023
* Remove _displayLinkOk * Discussions * Fix build
igordmn
approved these changes
Jul 10, 2023
|
Hurray! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored version of #710