Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code completion: named union case fields rule #500

Merged
merged 19 commits into from
Jun 28, 2023
Merged

Code completion: named union case fields rule #500

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
c3f228d
Very raw basic version.
nojaf Mar 13, 2023
b90e67a
Refactor and support scenario where existing fields are used.
nojaf Mar 13, 2023
fe9a05a
Add some invalid tree scenarios.
nojaf Mar 14, 2023
faa7349
Check if name is not qualified.
nojaf Mar 14, 2023
54671ab
Use navigator to get paren pat.
nojaf Mar 14, 2023
5343b8e
Minor clean-up.
nojaf Mar 17, 2023
a431dff
Add tests for ReparsedContext.Reference.
nojaf Mar 17, 2023
17f3ff0
Incomplete patterns.
nojaf Mar 17, 2023
062c0a6
Update incomplete match test.
nojaf Mar 17, 2023
557aed1
Find parent pattern via FieldPatNavigator.
nojaf Jun 21, 2023
658af3e
Auto open pop up for other named patterns.
nojaf Jun 27, 2023
c34ef08
Move tests to FSharpFilteredCompletionTest
nojaf Jun 27, 2023
5ed843e
Don't show any other lookup items when pattern is INamedUnionCaseFiel…
nojaf Jun 27, 2023
6f9bd9c
Update existing tests
nojaf Jun 27, 2023
3381368
Simplify
auduchinok Jun 27, 2023
4626feb
Make Rule available if no fields are left.
nojaf Jun 28, 2023
9e6bba3
Don't require all field names to be named.
nojaf Jun 28, 2023
5cb9269
Use correct field types in TextPresentation.
nojaf Jun 28, 2023
d259a3e
Add FSharpCodeCompletionTypingTests for NamedUnionCaseField.
nojaf Jun 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Auto open pop up for other named patterns.
  • Loading branch information
@nojaf
nojaf committed Jun 27, 2023
commit 658af3e5369d2d038f2c6d9327622c686f7f903b
2 changes: 2 additions & 0 deletions ...FSharp/src/FSharp.Psi.Features/src/CodeCompletion/Strategies/FSharpAutopopupStrategies.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,8 @@ type FSharpOnSpaceAutopopupStrategy() =
| :? IRecordFieldBinding as fieldBinding ->
fieldBinding.Semicolon == semi

| :? INamedUnionCaseFieldsPat as namedUnionCaseFieldsPat ->
namedUnionCaseFieldsPat.LastChild == semi
| _ -> false

| TokenType FSharpTokenType.LBRACE lbrace ->
Expand Down