Type Providers: add hot-reload for tp developers - #269
Open
Alex Berezhnykh (DedSec256) wants to merge 5 commits into
Open
Type Providers: add hot-reload for tp developers#269Alex Berezhnykh (DedSec256) wants to merge 5 commits into
Alex Berezhnykh (DedSec256) wants to merge 5 commits into
Conversation
Alex Berezhnykh (DedSec256)
force-pushed
the
net212-ber.a-restartTypeProvidersAction
branch
2 times, most recently
from
May 31, 2021 12:33
c127249 to
5e278ff
Compare
Alex Berezhnykh (DedSec256)
force-pushed
the
net212-ber.a-restartTypeProvidersAction
branch
3 times, most recently
from
June 7, 2021 16:00
ed40f59 to
57a5ba3
Compare
Alex Berezhnykh (DedSec256)
changed the title
Alex Berezhnykh (DedSec256)
requested review from
Friedrich von Never (ForNeVeR) and
Eugene Auduchinok (auduchinok)
June 21, 2021 12:40
Alex Berezhnykh (DedSec256)
force-pushed
the
net212-ber.a-restartTypeProvidersAction
branch
from
June 24, 2021 19:15
57a5ba3 to
ea1ca5e
Compare
Friedrich von Never (ForNeVeR)
approved these changes
Jun 29, 2021
Alex Berezhnykh (DedSec256)
force-pushed
the
net212-ber.a-restartTypeProvidersAction
branch
from
July 12, 2021 10:44
ea1ca5e to
fe561ae
Compare
Member
|
Alex Berezhnykh (@DedSec256) Could you target net213 instead please? Thanks. Also, there're some conflicts. 🙂 |
Alex Berezhnykh (DedSec256)
force-pushed
the
net212-ber.a-restartTypeProvidersAction
branch
from
July 15, 2021 21:50
b55b648 to
8b21f37
Compare
Alex Berezhnykh (DedSec256)
force-pushed
the
net212-ber.a-restartTypeProvidersAction
branch
from
July 15, 2021 22:05
8b21f37 to
7a3fbdb
Compare
| if not hasValue then failwith $"Cannot get type provider {id} from TypeProvidersCache" | ||
| else proxyTypeProvidersPerId.[id] | ||
|
|
||
| member x.GetProvidersLocations() = |
Collaborator
Author
There was a problem hiding this comment.
Better to use outputAssemblyPath since multiple projects can have the same resolutionFolder
Eugene Auduchinok (auduchinok)
force-pushed
the
net213
branch
from
July 26, 2021 15:56
c7f9e14 to
aa161bc
Compare
Collaborator
Author
|
We have no more need in manual 'Restart type providers' action since we are able to restart type providers via project reloading. |
Alex Berezhnykh (DedSec256)
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.