Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show documentation as hover docs #194

Closed
wants to merge 2 commits into from
Closed

Show documentation as hover docs #194

wants to merge 2 commits into from

Conversation

kirillgla
Copy link
Contributor

@kirillgla kirillgla commented Oct 20, 2020

We'll need to wait for some merge to finish and its code to arrive into the SDK before we can merge this, though

@kirillgla kirillgla marked this pull request as draft October 20, 2020 08:25
@kirillgla
Copy link
Contributor Author

JFYI, the code this PR depends on has just been merged into the platform

@kirillgla kirillgla marked this pull request as ready for review October 20, 2020 17:42
@auduchinok auduchinok closed this Oct 27, 2020
@auduchinok auduchinok reopened this Oct 27, 2020
@auduchinok
Copy link
Member

Triggering CI test. 🙂

@drhumlen
Copy link

What does this do? Do you have a screenshot? And will it be merged?

@auduchinok
Copy link
Member

auduchinok commented Dec 14, 2020

@drhumlen Using the updated APIs so it's in better sync with other languages. There're few issues had been uncovered, so the merge is postponed until the fix is ready.

@kirillgla
Copy link
Contributor Author

kirillgla commented Dec 15, 2020

The changes are purely cosmetic, they don't change the contents of the tooltips, but only the way they render. That's what new tooltips would look like:
image
Just for the record, there are two problems with this PR:

  • Incorrect background of the quick docs. Here's a ticket representing that
  • The horizontal line is too thick:
    image

@auduchinok
Copy link
Member

Closing a no longer required PR.
@kirillgla Thanks for making it work out of the box!

@auduchinok auduchinok closed this Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants