Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SimplifyLambdaFix #176

Merged
merged 23 commits into from
Sep 22, 2020
Merged

Add SimplifyLambdaFix #176

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
3f3ad44
added simplify lambda fix
DedSec256 Sep 16, 2020
7948bed
fix
DedSec256 Sep 16, 2020
c42225a
bug fixes
DedSec256 Sep 16, 2020
a394ad8
bug fixes
DedSec256 Sep 16, 2020
b29c775
simplify test
DedSec256 Sep 16, 2020
b86bd13
replace lambda fix added
DedSec256 Sep 16, 2020
457daea
added multiline test
DedSec256 Sep 16, 2020
6cdbdce
fixes
DedSec256 Sep 17, 2020
f9cd122
fixes
DedSec256 Sep 18, 2020
4eddbea
check fcs symbol settings in NamingService
DedSec256 Sep 18, 2020
52cad66
Simplify containsPat check, cleanup
auduchinok Sep 18, 2020
9fbd1b8
fix for struct tuples analyze
DedSec256 Sep 21, 2020
742408e
add replace with id fix
DedSec256 Sep 21, 2020
edc7c79
tests and fixes
DedSec256 Sep 21, 2020
e800e23
style fix
DedSec256 Sep 21, 2020
ad98a41
fix
DedSec256 Sep 21, 2020
d22f72f
small refactoring at 2:41 am
DedSec256 Sep 21, 2020
102ed8b
turn off analysis of external symbols until next iteration
DedSec256 Sep 22, 2020
8aba21e
Don't pass separate patterns collection to delete
auduchinok Sep 22, 2020
41cdf20
Check pattern name is not empty, don't get names several times
auduchinok Sep 22, 2020
c83b8ea
Disable failing test
auduchinok Sep 22, 2020
1d33188
use qualified names for references
DedSec256 Sep 22, 2020
992cd66
Disable failing test
auduchinok Sep 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
added multiline test
  • Loading branch information
@DedSec256 @auduchinok
DedSec256 authored and auduchinok committed Sep 22, 2020
commit 457daea68c45236ec83680b51a0c85af98e088a3
5 changes: 5 additions & 0 deletions ReSharper.FSharp/test/data/features/quickFixes/replaceLambda/Multiline.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
let f x y z = ()

fun x
y ->{caret} f [1,
2] x y
4 changes: 4 additions & 0 deletions ReSharper.FSharp/test/data/features/quickFixes/replaceLambda/Multiline.fs.gold
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
let f x y z = ()

f {caret}[1,
2]
1 change: 1 addition & 0 deletions ReSharper.FSharp/test/src/FSharp.Tests/QuickFixes/ReplaceLambdaTest.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ type ReplaceLambdaTest() =
[<Test>] member x.``Partial application``() = x.DoNamedTest()
[<Test>] member x.``Inner lambda``() = x.DoNamedTest()
[<Test>] member x.``Need parens``() = x.DoNamedTest()
[<Test>] member x.``Multiline``() = x.DoNamedTest()
[<Test; NotAvailable>] member x.``Non application - not available``() = x.DoNamedTest()


Expand Down