Improve Reflection API type hinting #1810
Draft
+111
−83
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ttemplate type name with something more readable - in one case this even fixed a bug becauseTwas defined for the entire class AND on a specific method.arraytype with something more specific - list or indexed array etc.@template TReflectedClass of UnitEnumDislcaimer:
E.g. the following would now fail (but it should have already): https://phpstan.org/r/09d7d483-6aad-41df-805e-75d44edbec32
It's worth noting that now it would also fail in "unsecured" cases e.g. if the method name was retrieved from somewhere returning
stringinstead ofnon-empty-string