This repository has been archived by the owner on Aug 10, 2021. It is now read-only.
Memory statistic #817
Merged
Memory statistic #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olonho
reviewed
Aug 29, 2017
runtime/src/main/cpp/Memory.h
Outdated
| @@ -17,6 +17,7 @@ | |||
| #ifndef RUNTIME_MEMORY_H | |||
| #define RUNTIME_MEMORY_H | |||
|
|
|||
| #include <cstdio> | |||
| #include "Assert.h" | |||
| #include "Common.h" | |||
| #include "TypeInfo.h" | |||
There was a problem hiding this comment.
Это лучше в Memory.cpp перенести.
olonho
reviewed
Aug 29, 2017
runtime/src/main/cpp/Memory.cpp
Outdated
| @@ -64,6 +66,13 @@ typedef KStdVector<ContainerHeader*> ContainerHeaderList; | |||
| typedef KStdVector<KRef*> KRefPtrList; | |||
| #endif | |||
|
|
|||
| #if MEMORY_STATISTIC | |||
| #define INC_UPDATE_REF_STATISTIC memoryStatistic.inc(old, object); | |||
| MemoryStatistic memoryStatistic; | |||
olonho
reviewed
Aug 29, 2017
runtime/src/main/cpp/Memory.cpp
Outdated
| void printStatistic() { | ||
| fprintf(stderr, "\nMemory manager statistic:\n"); | ||
| fprintf(stderr, "UpdateRef[null -> null ]: %lld\n", counters[0][0]); | ||
| fprintf(stderr, "UpdateRef[null -> permanent]: %lld\n", counters[0][1]); |
There was a problem hiding this comment.
Лучше konan::consolePrintf() и печатать все же в каком-то цикле.
There was a problem hiding this comment.
Так проще и нагляднее. В цикле придется делать массив с текстами
olonho
reviewed
Aug 29, 2017
runtime/src/main/cpp/Memory.cpp
Outdated
| fprintf(stderr, "UpdateRef[stack -> stack ]: %lld\n", counters[3][3]); | ||
| } | ||
| }; | ||
|
|
There was a problem hiding this comment.
А по количеству и месту аллокаций?
olonho
reviewed
Aug 29, 2017
runtime/src/main/cpp/Memory.cpp
Outdated
|
|
||
| #if MEMORY_STATISTIC | ||
| #define INC_UPDATE_REF_STATISTIC memoryState->statistic.incUpdateRef(old, object); | ||
| #define INIT_STATISTIC memoryState->statistic.init(); |
There was a problem hiding this comment.
Да тут-то не обязательно как с логгированием делать, можно и явно код писать под #if.
There was a problem hiding this comment.
Я могу вставить код под #if, но это снижает читабельность. Может так оставим?
olonho
force-pushed
the
memory_statistic
branch
from
fb120c3 to
5d7acfe
Compare
vvlevchenko
pushed a commit
that referenced
this pull request
Sep 4, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.