This repository has been archived by the owner on Aug 10, 2021. It is now read-only.
Fix Objective-C block to kotlin.Function* dynamic conversion #3499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
after migrating to synthetic function classes.
olonho
reviewed
Oct 25, 2019
| @@ -440,6 +440,9 @@ static OBJ_GETTER(boxedBooleanToKotlinImp, NSNumber* self, SEL cmd) { | |||
|
|
|||
| // Note: replaced by compiler in appropriate compilation modes. | |||
| __attribute__((weak)) convertReferenceFromObjC* Kotlin_ObjCExport_blockToFunctionConverters = nullptr; | |||
| __attribute__((weak)) int Kotlin_ObjCExport_blockToFunctionConverters_size = 0; | |||
|
|
|||
| extern "C" id objc_retainBlock(id self); | |||
There was a problem hiding this comment.
Why block retention is different from objects?
There was a problem hiding this comment.
There stack-allocated blocks, which are not exactly reference-counted. objc_retain on these blocks is no-op.
Stack-allocated blocks can be copied to heap, a copy is reference-counted and thus "escapable". objc_retainBlock on stack-allocated block performs such copying, and the result has RC=1; for heap-allocated blocks it simply increments RC.
olonho
approved these changes
Oct 25, 2019
homuroll
approved these changes
Oct 25, 2019
SvyatoslavScherbina
added a commit
that referenced
this pull request
Oct 28, 2019
after migrating to synthetic function classes.
SvyatoslavScherbina
added a commit
that referenced
this pull request
Oct 29, 2019
after migrating to synthetic function classes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
after migrating to synthetic function classes.