This repository has been archived by the owner on Aug 10, 2021. It is now read-only.
Update to XCode 11. #3375
Merged
Update to XCode 11. #3375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backend.native/llvm.def
Outdated
| @@ -47,6 +60,8 @@ excludedFunctions.mingw = LLVMDumpType | |||
|
|
|||
| excludedFunctions = LLVMInitializeAllAsmParsers LLVMInitializeAllAsmPrinters LLVMInitializeAllDisassemblers \ | |||
| LLVMInitializeAllTargetInfos LLVMInitializeAllTargetMCs LLVMInitializeAllTargets LLVMInitializeNativeTarget \ | |||
| LLVMInitializeNativeAsmParser LLVMInitializeNativeAsmPrinter LLVMInitializeNativeDisassembler | |||
| LLVMInitializeNativeAsmParser LLVMInitializeNativeAsmPrinter LLVMInitializeNativeDisassembler \ | |||
| LLVMInitializeNativeAsmParser LLVMInitializeNativeAsmPrinter LLVMInitializeNativeDisassembler \ | |||
There was a problem hiding this comment.
These ones excluded twice?
sbogolepov
reviewed
Sep 26, 2019
runtime/src/main/cpp/Porting.cpp
Outdated
| @@ -303,11 +303,12 @@ uint32_t inPages(uint32_t value) { | |||
| extern "C" void Konan_notify_memory_grow(); | |||
|
|
|||
| uint32_t memorySize() { | |||
| return __builtin_wasm_current_memory(); | |||
| // return __builtin_wasm_current_memory(); | |||
sbogolepov
reviewed
Sep 26, 2019
runtime/src/main/cpp/Porting.cpp
Outdated
| } | ||
|
|
||
| int32_t growMemory(uint32_t delta) { | ||
| int32_t oldLength = __builtin_wasm_grow_memory(delta); | ||
| int32_t oldLength = __builtin_wasm_memory_grow(0, delta); // __builtin_wasm_grow_memory(delta); |
| @@ -297,8 +297,8 @@ internal class Llvm(val context: Context, val llvmModule: LLVMModuleRef) { | |||
| } | |||
|
|
|||
| private fun importMemset(): LLVMValueRef { | |||
| val parameterTypes = cValuesOf(int8TypePtr, int8Type, int32Type, int32Type, int1Type) | |||
| val functionType = LLVMFunctionType(LLVMVoidType(), parameterTypes, 5, 0) | |||
| val parameterTypes = cValuesOf(int8TypePtr, int8Type, int32Type, int1Type) | |||
There was a problem hiding this comment.
memset was likely changed in llvm/llvm-project@1e68724
The commit message states that alignment should now be specified with an attribute.
We should ensure that proper alignment is applied for our memset usages.
There was a problem hiding this comment.
Fortunately we pointer align object slots where it's used, so likely not a big problem for us.
SvyatoslavScherbina
approved these changes
Sep 26, 2019
sbogolepov
reviewed
Sep 26, 2019
| @@ -125,6 +124,10 @@ internal inline fun<R> generateFunction(codegen: CodeGenerator, | |||
| startLocation, | |||
| endLocation, | |||
| function), code) | |||
|
|
|||
| // To perform per-function validation. | |||
| if (false) | |||
There was a problem hiding this comment.
We definitely need a handle (CLI flag?) for that. But it can be added in a separate PR.
sbogolepov
reviewed
Sep 26, 2019
| @@ -173,6 +173,7 @@ open class FrameworkTest : DefaultTask() { | |||
| } | |||
|
|
|||
| val args = listOf("--sdk", sdk, "-v", "-t", ldPath, frameworkBinary) | |||
| println("would run '$bitcodeBuildTool' with '$args") | |||
|
On windows: |
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.