This repository has been archived by the owner on Aug 10, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 564
Memory leak checker API. #3368
Merged
Merged
Memory leak checker API. #3368
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -81,6 +81,14 @@ public object Platform { | |
public val isDebugBinary: Boolean | ||
get() = Platform_isDebugBinary() | ||
|
||
/** | ||
* If the memory leak checker is activated, by default true in debug mode, false in release. | ||
* When memory leak checker is activated, and leak detected on process termination process | ||
* is terminated with non-zero exit code. | ||
*/ | ||
public var hasMemoryLeakChecker: Boolean | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The name doesn't correspond to the behaviour. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Renamed. |
||
get() = Platform_getMemoryLeakChecker() | ||
set(value) = Platform_setMemoryLeakChecker(value) | ||
} | ||
|
||
@SymbolName("Konan_Platform_canAccessUnaligned") | ||
|
@@ -99,4 +107,10 @@ private external fun Platform_getCpuArchitecture(): Int | |
private external fun Platform_getMemoryModel(): Int | ||
|
||
@SymbolName("Konan_Platform_isDebugBinary") | ||
private external fun Platform_isDebugBinary(): Boolean | ||
private external fun Platform_isDebugBinary(): Boolean | ||
|
||
@SymbolName("Konan_Platform_getMemoryLeakChecker") | ||
private external fun Platform_getMemoryLeakChecker(): Boolean | ||
|
||
@SymbolName("Konan_Platform_setMemoryLeakChecker") | ||
private external fun Platform_setMemoryLeakChecker(value: Boolean): Unit |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, forgot to push update doc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error message without termination is somewhat undiscoverable (including leaks in Kotlin/Native tests). Why not terminate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, OK, will update message as well.