This repository has been archived by the owner on Aug 10, 2021. It is now read-only.
Support -Xexport-library in reverse C interop. #2740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -283,7 +283,8 @@ private fun selectExportedLibraries( | |||
| ): List<String> { | |||
| val exportedLibraries = arguments.exportedLibraries?.toList().orEmpty() | |||
|
|
|||
| return if (exportedLibraries.isNotEmpty() && outputKind != CompilerOutputKind.FRAMEWORK) { | |||
| return if (exportedLibraries.isNotEmpty() && outputKind != CompilerOutputKind.FRAMEWORK && | |||
| outputKind != CompilerOutputKind.STATIC && outputKind != CompilerOutputKind.DYNAMIC) { | |||
There was a problem hiding this comment.
Maybe fix error message below too?
| moduleDescriptors += context.moduleDescriptor | ||
| moduleDescriptors += context.getExportedDependencies() | ||
|
|
||
| currentPackageFragments = context.moduleDescriptor.getPackageFragments().sortedWith( |
There was a problem hiding this comment.
Maybe include exported dependencies' package fragments too?
There was a problem hiding this comment.
But why, looks like everything is exported anyway (as descriptor tree contains all them).
There was a problem hiding this comment.
What is currentPackageFragments for then?
SvyatoslavScherbina
approved these changes
Mar 1, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.