Use unsigned types in interop #1913

SvyatoslavScherbina · 2018-08-21T12:56:33Z

No description provided.

olonho · 2018-08-21T16:19:13Z

INTEROP.md

@@ -468,28 +468,24 @@ Sometimes the C libraries have function parameters or struct fields of
 platform-dependent type, e.g. `long` or `size_t`. Kotlin itself doesn't provide
 neither implicit integer casts nor C-style integer casts (e.g.
 `(size_t) intValue`), so to make writing portable code in such cases easier,
-the following methods are provided:
+`convert` method is provided:


Why not fit?

Because fit doesn't fit.

olonho · 2018-08-21T16:19:57Z

INTEROP.md


 ```
 fun zeroMemory(buffer: COpaquePointer, size: Int) {
-    memset(buffer, 0, size.signExtend<size_t>())
+    memset(buffer, 0, size.convert<size_t>())


Is <size_t> needed?

See the refinement below.

Can convert be made an extension property at least?

olonho · 2018-08-21T16:23:08Z

Interop/Runtime/src/main/kotlin/kotlinx/cinterop/Generated.kt

 inline operator fun <T : Double> CPointer<DoubleVarOf<T>>.get(index: Long): T =
        (this + index)!!.pointed.value

+@JvmName("set\$Double")
 inline operator fun <T : Double> CPointer<DoubleVarOf<T>>.set(index: Long, value: T) {
    (this + index)!!.pointed.value = value
 }


Maybe use Kotlin/Native proggy to generate definitions :)?

olonho · 2018-08-21T16:23:56Z

Interop/Runtime/src/main/kotlin/kotlinx/cinterop/Types.kt

@@ -246,7 +246,7 @@ sealed class CPrimitiveVar(rawPtr: NativePtr) : CVariable(rawPtr) {
 }

 interface CEnum {
-    val value: Number
+    val value: Any


Signed an unsigned types has no common supertype?

olonho · 2018-08-21T16:26:34Z

Interop/Runtime/src/native/kotlin/kotlinx/cinterop/Pinning.kt

@@ -79,3 +92,15 @@ private external fun getAddressOfElement(array: Any, index: Int): COpaquePointer
 @Suppress("NOTHING_TO_INLINE")
 private inline fun <P : CVariable> Pinned<*>.addressOfElement(index: Int): CPointer<P> =
        getAddressOfElement(this.get(), index).reinterpret()
+
+@SymbolName("Kotlin_Arrays_getAddressOfElement")


Maybe specialized versions here and above?

I don't believe specialization would have any measurable effect here.

olonho · 2018-08-21T16:30:26Z

...p/StubGenerator/src/main/kotlin/org/jetbrains/kotlin/native/interop/gen/jvm/StubGenerator.kt

@@ -156,6 +156,12 @@ class StubGenerator(
        override fun getPackageFor(declaration: TypeDeclaration): String {
            return imports.getPackage(declaration.location) ?: pkgName
        }
+
+        override val useUnsignedTypes: Boolean


olonho · 2018-08-21T16:33:42Z

backend.native/tests/interop/basics/bf.kt

    check(s, x1, x2, x3, x4, x5, x6)

-    assignReversed(s, x1 + 2, x2, (x3 + 8).toShort(), x4 - 16, x5 + 32, x6 + Long.MIN_VALUE)
+    assignReversed(s, x1 + 2, x2, (x3 + 8u).toUShort(), x4 - 16u, x5 + 32, x6 + Long.MIN_VALUE)


Do we have unsigned in C ellipsis cases?

What do you mean?

Passing unsigned types to C void foo(int, ...)

I have supported it with this PR.

olonho · 2018-08-21T16:34:43Z

backend.native/tests/interop/basics/opengl_teapot.kt

@@ -13,7 +13,7 @@ private val windowHeight = 480

 fun display() {
    // Clear Screen and Depth Buffer
-    glClear(GL_COLOR_BUFFER_BIT or GL_DEPTH_BUFFER_BIT)
+    glClear((GL_COLOR_BUFFER_BIT or GL_DEPTH_BUFFER_BIT).convert())


olonho · 2018-08-21T16:37:37Z

backend.native/tests/interop/platform_zlib.kt

-            next_out = pinned.addressOf(0)
-            avail_out = buffer.size
+            avail_in = 8u
+            next_out = pinned.addressOf(0).reinterpret()


Why not UByteArray then?

Because buffer is decoded to String below.

olonho · 2018-08-21T16:39:35Z

samples/nonBlockingEchoServer/src/main/kotlin/EchoServer.kt

                val connectionIdString = "#${++connectionId}: ".cstr
                val connectionIdBytes = connectionIdString.ptr

                try {
                    while (true) {
                        val length = read(buffer, bufferLength)

-                        if (length == 0L)
+                        if (length == 0uL)


So we still cannot auto-assign 0uL?

olonho reviewed Aug 21, 2018

View reviewed changes

SvyatoslavScherbina force-pushed the interop-unsigned-types branch from 72e7b5a to c2fb75f Compare August 21, 2018 19:18

SvyatoslavScherbina changed the base branch from 1.3-M2 to master August 21, 2018 19:18

SvyatoslavScherbina added 5 commits August 24, 2018 18:20

Use unsigned types in interop

4e1716d

fixup! Use unsigned types in interop

ad878c7

fixup! Use unsigned types in interop

19870bf

fixup! Use unsigned types in interop

c5dd4ef

fixup! Use unsigned types in interop

7dc0ae5

SvyatoslavScherbina force-pushed the interop-unsigned-types branch from e619950 to 7dc0ae5 Compare August 24, 2018 15:25

SvyatoslavScherbina merged commit 8f1b94f into master Aug 24, 2018

SvyatoslavScherbina deleted the interop-unsigned-types branch August 24, 2018 15:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use unsigned types in interop #1913

Use unsigned types in interop #1913

SvyatoslavScherbina commented Aug 21, 2018 •

edited

Loading

olonho Aug 21, 2018

SvyatoslavScherbina Aug 21, 2018

olonho Aug 21, 2018

SvyatoslavScherbina Aug 21, 2018

olonho Aug 23, 2018

olonho Aug 21, 2018

olonho Aug 21, 2018

SvyatoslavScherbina Aug 21, 2018

olonho Aug 21, 2018

SvyatoslavScherbina Aug 21, 2018

olonho Aug 21, 2018

olonho Aug 21, 2018

SvyatoslavScherbina Aug 21, 2018

olonho Aug 22, 2018

SvyatoslavScherbina Aug 22, 2018

olonho Aug 23, 2018

olonho Aug 21, 2018

olonho Aug 21, 2018

SvyatoslavScherbina Aug 21, 2018

olonho Aug 21, 2018

Use unsigned types in interop #1913

Use unsigned types in interop #1913

Conversation

SvyatoslavScherbina commented Aug 21, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SvyatoslavScherbina commented Aug 21, 2018 •

edited

Loading